-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DA: Verifier and Indexer in Node #713
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Except for the verification with public keys which I think should be removed from the verifier is ok. It can be done in a different pr though.
let secret_key = | ||
SecretKey::from_bytes(&bytes).expect("Secret key should be reconstructed from bytes"); | ||
|
||
let nodes_public_keys = settings | ||
.nodes_public_keys | ||
.iter() | ||
.map(|pk_hex| { | ||
let pk_bytes = | ||
hex::decode(pk_hex).expect("Public key string should decode to bytes"); | ||
PublicKey::from_bytes(&pk_bytes) | ||
.expect("Public key should be reconstructed from bytes") | ||
}) | ||
.collect::<Vec<PublicKey>>(); | ||
|
||
let verifier = NomosKzgrsVerifier::new(secret_key, &nodes_public_keys); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not needed anymore. But i have to check on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen that sk is not used anymore, but the index is still required. Lets do it in a separate PR.
ce3f663
to
79867fc
Compare
Verifier and Indexer services were created and tested in a simplified node, this PR integrates them into the Nomos Node.